[Tests-Only]Fixed failing test on public link share #3852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Talank
force-pushed
the
fix-test-sharePublicLink
branch
from
265bde5 to
b63a8a6
Compare
dpakach
reviewed
Jul 30, 2020
| if (timeSinceLastShare <= 1001) { | ||
| await client.pause(1001 - timeSinceLastShare) | ||
| } | ||
| timeOfLastShareOperation = Date.now() |
There was a problem hiding this comment.
I think this should be updated after sharing as sharing might take some time
Talank
force-pushed
the
fix-test-sharePublicLink
branch
from
d65b4dd to
81d5d1b
Compare
dpakach
reviewed
Jul 31, 2020
| @@ -510,6 +529,7 @@ Given( | |||
| null, | |||
| { password: password } | |||
| ) | |||
| await updateTimeOfLastShareOperation() | |||
There was a problem hiding this comment.
add this line in shareFilefolder() function as there are other steps too that do share.
Talank
force-pushed
the
fix-test-sharePublicLink
branch
from
81d5d1b to
928b9bf
Compare
Talank
force-pushed
the
fix-test-sharePublicLink
branch
from
928b9bf to
a4042ad
Compare
individual-it
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test
Scenario: user edits the password of an already existing public link and tries to access with old passwordwas failing because two shares were created fast with the samestime. So, a new function is created to wait for at least one second between the creation of shares.Related Issue
How Has This Been Tested?
Types of changes
Checklist: