Media viewer video navigation #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Video and/or image were still visible during navigating to the next or previous item in mediaviewer. Needed to replace the <template>-tag with a <div>-tag for that.
This comment has been minimized.
This comment has been minimized.
kulmann
added
Status:Needs-Review
LukasHirt
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the navigation between video elements in media viewer. When navigating back and forth between two videos, the shown video stayed the same before. Now it actually switches to the desired video.
As a bonus, this PR fixes animations. There were glitches during switching from one medium to the next/previous, where the loaded medium was shown at the bottom of the screen and then jumped back up after load. That is solved by switching the
templateto adivtag. Also, the animations need each element to have a unique key, otherwise the animation will not appear at all. That is solved by adding the file-id to the respective key (which was needed for videos anyway).Related Issue
Motivation and Context
Fixing bugs...
Types of changes
Checklist: