Feature/copy move in same location #3847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
DeepDiver1975
force-pushed
the
feature/copy-move-in-same-location
branch
from
3b9e3e5 to
74cab43
Compare
LukasHirt
reviewed
Jul 28, 2020
| > | ||
| <span v-text="confirmBtnText" /> | ||
| </oc-button> | ||
| <span v-if="!canConfirm" :uk-tooltip="sameLocationToolTip"> |
There was a problem hiding this comment.
Add pls key to if else. There might be an issue with rendering without it https://vuejs.org/v2/style-guide/#v-if-v-else-if-v-else-without-key-use-with-caution
| <span v-text="confirmBtnText" /> | ||
| </oc-button> | ||
| </span> | ||
| <span v-else> |
There was a problem hiding this comment.
Is the wrapping span needed?
There was a problem hiding this comment.
uk-tooltip on a disabled button is not working (ie11 🤮 ) and therefore it needs wrapping spans/divs
LukasHirt
approved these changes
Jul 28, 2020
|
please rebase! |
|
close this due inactivity, feel free to reopen if still a thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case of move it is not allowed to move resources into the source destination. The action button will be disabled
When copying to the same location a postfix will be applied.
Related Issue
How Has This Been Tested?
: ✋
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: