Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] use openid-connect insecure and not debug setting #3829

Merged
merged 2 commits into from
Jul 27, 2020
Merged

[tests-only] use openid-connect insecure and not debug setting #3829

merged 2 commits into from
Jul 27, 2020

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Jul 27, 2020 •
edited
Loading

Description

owncloud/openidconnect#89 introduced a new setting to accept insecure certificates, so in CI use the new setting and not debug

Related Issue

should help with #3797

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@individual-it individual-it marked this pull request as ready for review July 27, 2020 11:50
@individual-it individual-it requested review from kulmann and butonic July 27, 2020 11:50
@individual-it individual-it self-assigned this Jul 27, 2020
kulmann
kulmann approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@butonic
Copy link
Member

butonic commented Jul 27, 2020 •
edited
Loading

@individual-it a timeout ... any idea?


1) Scenario: user edits the password of an already existing public link and tries to access with old password (attempt 2) # tests/acceptance/features/webUISharingPublic/shareByPublicLink.feature:392 | 1123s
-- | --
3316 | ✔ Before # tests/acceptance/setup.js:28 | 1123s
3317 | ✔ Before # tests/acceptance/setup.js:32 | 1123s
3318 | ✔ Before # tests/acceptance/setup.js:36 | 1123s
3319 | ✔ Before # tests/acceptance/setup.js:46 | 1123s
3320 | ✔ Before # tests/acceptance/setup.js:68 | 1123s
3321 | ✔ Before # tests/acceptance/setup.js:75 | 1123s
3322 | ✔ Before # tests/acceptance/stepDefinitions/filesContext.js:18 | 1123s
3323 | ✔ Before # tests/acceptance/stepDefinitions/generalContext.js:228 | 1123s
3324 | ✔ Before # tests/acceptance/stepDefinitions/generalContext.js:267 | 1123s
3325 | ✔ Given user "user1" has been created with default attributes # tests/acceptance/stepDefinitions/provisioningContext.js:126 | 1123s
3326 | ✔ Given user "user1" has shared folder "simple-folder" with link with "read, update, create, delete" permissions and password "pass123" # tests/acceptance/stepDefinitions/sharingContext.js:501 | 1123s
3327 | ✔ And user "user1" has created a public link with following settings # tests/acceptance/stepDefinitions/sharingContext.js:547 | 1123s
3328 | \| path        \| simple-folder                \| | 1123s
3329 | \| name        \| Public-link                  \| | 1123s
3330 | \| permissions \| read, update, create, delete \| | 1123s
3331 | \| password    \| pass123                      \| | 1123s
3332 | ✔ And user "user1" has logged in using the webUI # tests/acceptance/stepDefinitions/loginContext.js:67 | 1123s
3333 | ✔ And the user edits the public link named "Public-link" of folder "simple-folder" changing following # tests/acceptance/stepDefinitions/publicLinkContext.js:139 | 1123s
3334 | \| password \| qwertyui \| | 1123s
3335 | ✔ When the public uses the webUI to access the last public link created by user "user1" with password "pass123" # tests/acceptance/stepDefinitions/publicLinkContext.js:68 | 1123s
3336 | ✖ Then the public should not get access to the publicly shared file # tests/acceptance/stepDefinitions/publicLinkContext.js:115 | 1123s
3337 | Timed out while waiting for element <input[type=password]> to be present for 20000 milliseconds. - expected "visible" but got: "not found" (20003ms) | 1123s
3338 | Timed out while waiting for element <input[type=password]> to be present for 20000 milliseconds. - expected "visible" but got: "not found" (20003ms) | 1123s
3339 | at Proxy.submitLinkPasswordForm (/var/www/owncloud/phoenix/tests/acceptance/pageObjects/publicLinkPasswordPage.js:46:12) | 1123s
3340 | at _callee10$ (/var/www/owncloud/phoenix/tests/acceptance/stepDefinitions/publicLinkContext.js:118:6) | 1123s
3341 | at new Promise (<anonymous>) | 1123s
3342 | ✔ After # tests/acceptance/stepDefinitions/provisioningContext.js:200 | 1123s
3343 | ✔ After # tests/acceptance/stepDefinitions/generalContext.js:272 | 1123s
3344 | ✔ After # tests/acceptance/stepDefinitions/generalContext.js:252 | 1123s
3345 | ✔ After # tests/acceptance/setup.js:110 | 1123s
3346 | ✔ After # tests/acceptance/setup.js:106 | 1123s
3347 | ✔ After # tests/acceptance/setup.js:102 | 1123s
3348 | ✔ After # tests/acceptance/setup.js:95 | 1123s
3349 | ✔ After # tests/acceptance/setup.js:86 | 1123s
3350 | ✔ After # tests/acceptance/setup.js:54 | 1123s
3351 |   | 1123s
3352 | Warnings: | 1123s
3353 |   | 1123s
3354 | 1) Scenario: user edits the password of an already existing public link and tries to access with old password (attempt 1, retried) # tests/acceptance/features/webUISharingPublic/shareByPublicLink.feature:392 | 1123s
3355 | ✔ Before # tests/acceptance/setup.js:28 | 1123s
3356 | ✔ Before # tests/acceptance/setup.js:32 | 1123s
3357 | ✔ Before # tests/acceptance/setup.js:36 | 1123s
3358 | ✔ Before # tests/acceptance/setup.js:46 | 1123s
3359 | ✔ Before # tests/acceptance/setup.js:68 | 1123s
3360 | ✔ Before # tests/acceptance/setup.js:75 | 1123s
3361 | ✔ Before # tests/acceptance/stepDefinitions/filesContext.js:18 | 1123s
3362 | ✔ Before # tests/acceptance/stepDefinitions/generalContext.js:228 | 1123s
3363 | ✔ Before # tests/acceptance/stepDefinitions/generalContext.js:267 | 1123s
3364 | ✔ Given user "user1" has been created with default attributes # tests/acceptance/stepDefinitions/provisioningContext.js:126 | 1123s
3365 | ✔ Given user "user1" has shared folder "simple-folder" with link with "read, update, create, delete" permissions and password "pass123" # tests/acceptance/stepDefinitions/sharingContext.js:501 | 1123s
3366 | ✔ And user "user1" has created a public link with following settings # tests/acceptance/stepDefinitions/sharingContext.js:547 | 1123s
3367 | \| path        \| simple-folder                \| | 1123s
3368 | \| name        \| Public-link                  \| | 1123s
3369 | \| permissions \| read, update, create, delete \| | 1123s
3370 | \| password    \| pass123                      \| | 1123s
3371 | ✔ And user "user1" has logged in using the webUI # tests/acceptance/stepDefinitions/loginContext.js:67 | 1123s
3372 | ✔ And the user edits the public link named "Public-link" of folder "simple-folder" changing following # tests/acceptance/stepDefinitions/publicLinkContext.js:139 | 1123s
3373 | \| password \| qwertyui \| | 1123s
3374 | ✔ When the public uses the webUI to access the last public link created by user "user1" with password "pass123" # tests/acceptance/stepDefinitions/publicLinkContext.js:68 | 1123s
3375 | ✖ Then the public should not get access to the publicly shared file # tests/acceptance/stepDefinitions/publicLinkContext.js:115 | 1123s
3376 | Timed out while waiting for element <input[type=password]> to be present for 20000 milliseconds. - expected "visible" but got: "not found" (20016ms) | 1123s
3377 | Timed out while waiting for element <input[type=password]> to be present for 20000 milliseconds. - expected "visible" but got: "not found" (20016ms) | 1123s
3378 | at Proxy.submitLinkPasswordForm (/var/www/owncloud/phoenix/tests/acceptance/pageObjects/publicLinkPasswordPage.js:46:12) | 1123s
3379 | at _callee10$ (/var/www/owncloud/phoenix/tests/acceptance/stepDefinitions/publicLinkContext.js:118:6) | 1123s
3380 | at new Promise (<anonymous>) | 1123s
3381 | ✔ After # tests/acceptance/stepDefinitions/provisioningContext.js:200 | 1123s
3382 | ✔ After # tests/acceptance/stepDefinitions/generalContext.js:272 | 1123s
3383 | ✔ After # tests/acceptance/stepDefinitions/generalContext.js:252 | 1123s
3384 | ✔ After # tests/acceptance/setup.js:110 | 1123s
3385 | ✔ After # tests/acceptance/setup.js:106 | 1123s
3386 | ✔ After # tests/acceptance/setup.js:102 | 1123s
3387 | ✔ After # tests/acceptance/setup.js:95 | 1123s
3388 | ✔ After # tests/acceptance/setup.js:86 | 1123s
3389 | ✔ After # tests/acceptance/setup.js:54

@individual-it individual-it mentioned this pull request Jul 27, 2020
Closed
@individual-it individual-it force-pushed the useOpenidConnectInsecure branch from 9237782 to 0f32cbd Compare July 27, 2020 13:51
@individual-it
Copy link
Member Author

@butonic I'm guessing the reason in #3773 (but tests passed there) I've opened an issue #3830 for investigation and the test is skipped in 0f32cbd

@kulmann kulmann merged commit d5e39c8 into master Jul 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the useOpenidConnectInsecure branch July 27, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@butonic butonic Awaiting requested review from butonic

Assignees

@individual-it individual-it

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@individual-it @butonic @kulmann