Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Shared with:" from file list rows #3808

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Remove "Shared with:" from file list rows #3808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5b188e
Remove "Shared with:" from file list rows
pmaier1 Jul 22, 2020
598bb27
Remove the "no indicators" indicator
kulmann Jul 23, 2020
99a4532
Add changelog item
kulmann Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions apps/files/src/components/FileItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,14 @@
v-text="'.' + item.extension"
/>
</div>
<div v-if="hasTwoRows" class="uk-flex uk-flex-middle">
<translate class="uk-margin-small-right">Shared with:</translate>
<div v-if="hasTwoRows && hasIndicators" class="uk-flex uk-flex-middle">
<Indicators
v-if="indicators.length > 0"
key="status-indicators"
:default-indicators="indicators"
:item="item"
:are-indicators-clickable="areIndicatorsClickable"
class="files-list-indicators"
/>
<span v-else key="no-status-indicators" aria-hidden="true" v-text="'-'" />
</div>
</div>
</div>
Expand Down Expand Up @@ -133,6 +130,10 @@ export default {
davUrl = ['..', 'dav', 'files', this.$store.getters.user.id].join('/')
}
return this.$client.files.getFileUrl(davUrl)
},

hasIndicators() {
return this.indicators.length > 0
}
},
mounted() {
Expand Down
6 changes: 6 additions & 0 deletions changelog/unreleased/remove-shared-with
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Change: Get rid of static "Shared with:" label

We removed the static "Shared with:" text label in the indicator row of file items. From now on, if a file item has no indicators, it will fall back to the one-row layout (resource name vertically centered).

https://github.com/owncloud/product/issues/123
https://github.com/owncloud/phoenix/pull/3808