Feature/copy #3749
Feature/copy #3749
Conversation
|
PR rebased and ready for review |
| | "question?" | "folder-with-question?" | | ||
| | "&and#hash" | "folder-with-&and#hash" | | ||
|
|
||
| @skipOnOCIS @issue-3755 |
| isRowDisabled(resource) { | ||
| const isBeingMoved = this.resources.some(item => item === resource.path) | ||
|
|
||
| return resource.type !== 'folder' || !resource.canCreate() || isBeingMoved |
There was a problem hiding this comment.
nice, so your are indeed checking the perm on the target folder 👍
There was a problem hiding this comment.
would be good to add a test for the case(s) where a target folder is not targettable due to missing permissions (received read-only share)
There was a problem hiding this comment.
I've opened a ticket for collecting the next scenarios to test for copy and move. Should I add this in there or implement it already in this PR?
There was a problem hiding this comment.
later is fine, please label the ticket "QA-team" and ping Artur
There was a problem hiding this comment.
later... but within the sprint would be good because else I don't think we can consider the task "done"
| @@ -139,6 +140,12 @@ module.exports = { | |||
| */ | |||
| move: function(target) { | |||
There was a problem hiding this comment.
Just seeing that the target param is not used in the function body, so you could remove it.
There was a problem hiding this comment.
Must have overlooked this. Nice catch!
Fix promise and properly handle errors Add acceptance tests Merge move and copy in locationPicker tests Add batch copy Add copy file action in tests Fix copy error message Add permissions check for copy in public links Add permissions check for batch copy action in public links Fix copy file action in tests Fix error message in copy tests Add changelog Add translations context and adjust guides for copy Skip public links test in oCIS Remove target from move
Description
We've added copy action to the files list. It is possible now to copy folders and files.
The copy is executed via location picker.
Related Issue
How Has This Been Tested?
Types of changes
Open tasks: