Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply proper file type icons also for uppercase file extensions #3670

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

DeepDiver1975
Copy link
Member

Description

Uppercase file extensions now receive proper icon

How Has This Been Tested?

  • upload file.PDF and see the proper pdf icon

Screenshots (if appropriate):

Just wrong icon ...
Screenshot from 2020-06-24 16-40-07

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 24, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 self-assigned this Jun 24, 2020
@DeepDiver1975 DeepDiver1975 requested a review from LukasHirt June 24, 2020 14:41
@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/uppercase-file-extensions branch from 4df83e6 to 52d1659 Compare June 24, 2020 14:43
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@kulmann kulmann merged commit 884ac9a into master Jun 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/uppercase-file-extensions branch June 24, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants