-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework account dropdown #3605
Rework account dropdown #3605
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
d4777b3
to
60a8248
Compare
The design is still a bit off from mockups in Figma but I think to achieve that we should first adjust the oc-drop component itself. |
Pushed a new commit regarding the tests. Locally it's passing fine. Let's see here. |
fd07d81
to
390b751
Compare
Ok, hopefully, the last one. Was missing id in the logout item. |
What about the size of the drop? The default size of 300px looks way too big for this menu. Do we have a way to shrink it to the width of the list items? 🤔 |
I originally didn't want to touch the UI of the dropdown before we do something with the drop component itself. But yeah, this is a quick win. Width decreased to the content width 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! 👍
We've removed user avatar, user email and version from the account dropdown. The log out button has been changed into a link. All links in account dropdown are now inside of a list.
664a876
to
b932857
Compare
Description
We've removed user avatar, user email and version from the account dropdown.
The log out button has been changed into a link.
All links in account dropdown are now inside of a list.
Related Issue
Motivation and Context
Keep focus only on the actionable items inside of the dropdown.
Screenshots (if appropriate):
Types of changes