Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework account dropdown #3605

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Rework account dropdown #3605

merged 1 commit into from
Jun 16, 2020

Conversation

LukasHirt
Copy link
Collaborator

Description

We've removed user avatar, user email and version from the account dropdown.
The log out button has been changed into a link.
All links in account dropdown are now inside of a list.

Related Issue

Motivation and Context

Keep focus only on the actionable items inside of the dropdown.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@LukasHirt LukasHirt self-assigned this Jun 15, 2020
@update-docs
Copy link

update-docs bot commented Jun 15, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@LukasHirt LukasHirt force-pushed the rework-account-dropdown branch from d4777b3 to 60a8248 Compare June 15, 2020 12:16
@LukasHirt LukasHirt marked this pull request as ready for review June 15, 2020 12:16
@LukasHirt LukasHirt requested review from kulmann and PVince81 June 15, 2020 12:17
@LukasHirt
Copy link
Collaborator Author

The design is still a bit off from mockups in Figma but I think to achieve that we should first adjust the oc-drop component itself.

@LukasHirt
Copy link
Collaborator Author

Pushed a new commit regarding the tests. Locally it's passing fine. Let's see here.

@LukasHirt LukasHirt force-pushed the rework-account-dropdown branch from fd07d81 to 390b751 Compare June 16, 2020 08:39
@LukasHirt
Copy link
Collaborator Author

Ok, hopefully, the last one. Was missing id in the logout item.

@kulmann
Copy link
Member

kulmann commented Jun 16, 2020

What about the size of the drop? The default size of 300px looks way too big for this menu. Do we have a way to shrink it to the width of the list items? 🤔

@LukasHirt
Copy link
Collaborator Author

What about the size of the drop? The default size of 300px looks way too big for this menu. Do we have a way to shrink it to the width of the list items? 🤔

I originally didn't want to touch the UI of the dropdown before we do something with the drop component itself. But yeah, this is a quick win. Width decreased to the content width 😉

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 👍

@kulmann
Copy link
Member

kulmann commented Jun 16, 2020

For the record:
Screenshot 2020-06-16 at 20 15 29

We've removed user avatar, user email and version from the account dropdown.
The log out button has been changed into a link.
All links in account dropdown are now inside of a list.
@LukasHirt LukasHirt force-pushed the rework-account-dropdown branch from 664a876 to b932857 Compare June 16, 2020 18:28
@LukasHirt LukasHirt merged commit 0c93a0e into master Jun 16, 2020
@LukasHirt LukasHirt deleted the rework-account-dropdown branch June 16, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework account dropdown
2 participants