Remove sidebar quickAccess extension point #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
previously approved these changes
Jun 9, 2020
|
Code looks good... tests are failing |
I think we are using the quickAccess in most (if not all) collaborators tests. I'll see tomorrow what I can do with it. |
|
@kulmann I have pushed a new commit which is touching the tests. I am using now the |
We have removed the sidebar quickAccess extension point. To create an quick access to the sidebar, we need to use the quickActions extension point.
LukasHirt
force-pushed
the
change/remove-sidebar-quick-access
branch
from
5e4b0ae to
7f9fb3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Motivation and Context
Cleaner code and less extension points to maintain.
How Has This Been Tested?
Types of changes