Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete (and duplicate) error alert #3342

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Remove obsolete (and duplicate) error alert #3342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions apps/files/src/components/ocDialogPrompt.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@
:fix-message-line="true"
class="oc-dialog-prompt-input-offset"
></oc-text-input>
<transition name="custom-classes-transition"
enter-active-class="uk-animation-slide-left-small uk-animation-fast"
leave-active-class="uk-animation-slide-right-small uk-animation-fast uk-animation-reverse">
<oc-alert v-if="ocErrorDelayed" class="oc-dialog-prompt-alert" :noClose="true" variation="danger">
{{ ocErrorDelayed }}
</oc-alert>
</transition>
<oc-loader v-if="ocLoading"></oc-loader>
</template>
<template slot="footer">
Expand Down
6 changes: 6 additions & 0 deletions changelog/unreleased/3342
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Remove duplicate error display in input prompt

Validation errors within the input prompt dialog were showing up twice. One of them is a leftover from the
old version. We've fixed the dialog by removing the old validation error type.

https://github.com/owncloud/phoenix/pull/3342