-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show token string if link name is empty in FileLinkSidebar #3297
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
8bdc64e
to
bfa20fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Add just changelog pls
Would be good to have tests that check that the name of a unnamed link is really something that looks like the token. Something like
please ping me if you need help with it |
b26bf5b
to
0c7a017
Compare
tests/acceptance/features/webUISharingPublic/shareByPublicLink.feature
Outdated
Show resolved
Hide resolved
d5a313d
to
0931ad3
Compare
7184a07
to
3851d22
Compare
3851d22
to
954b772
Compare
@individual-it I have added both a new scenario similar to your suggestion and, a changelog entry. Please review them, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests look good
@individual-it did you mistakenly click "request changes" instead of "approve" ? |
Description
owncloud-js-client was parsing empty link name xml attribute as empty object. Empty object was changed with an empty string in store action.
Also, now FileLinkSidebar shows token string as name for the link shares without a name.
Related Issue
How Has This Been Tested?
Types of changes
Checklist: