Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove first char in etag #3274

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Do not remove first char in etag #3274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/files/src/components/FileItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export default {
if (this.item.etag) {
// add etag for URL based caching
// strip double quotes from etag
query.c = this.item.etag.substr(2, this.item.etag.length - 2)
query.c = this.item.etag.substr(1, this.item.etag.length - 2)
}

let itemPath = this.item.path
Expand Down
6 changes: 6 additions & 0 deletions changelog/unreleased/3274
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Do not remove first character of etag

When stripping away double quotes in etag of the file thumbnails, we accidentally
removed first character as well. We've stopped removing that character.

https://github.com/owncloud/phoenix/pull/3274