Use alternative temporary ids for uniqueness in views #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2020
LukasHirt
approved these changes
Mar 23, 2020
kulmann
approved these changes
Mar 23, 2020
dpakach
force-pushed
the
fix-ids-as-string
branch
from
5cf327b to
8419a07
Compare
|
@PVince81 I just rebased this PR since the OCIS tests are failing and those have been skipped for now. |
When using OCIS as backend, the ids of resources is a string instead of integer. So we cannot embed those into DOM node ids and need to use another alternative. This fix introduces a unique listId which is only there to provide uniqueness across the current list and should not be used for any data related operation. This fixes the file actions menu when using OCIS as backend.
PVince81
force-pushed
the
fix-ids-as-string
branch
from
8419a07 to
9ac4081
Compare
|
@kulmann you're right, I was also not comfortable with the name. I've renamed all listId to viewId now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using OCIS as backend, the ids of resources is a string instead of
integer. So we cannot embed those into DOM node ids and need to use
another alternative. This fix introduces a unique listId which is only
there to provide uniqueness across the current list and should not be
used for any data related operation.
This fixes the file actions menu when using OCIS as backend.
Related Issue
Fixes #3214
Fixes owncloud/ocis-phoenix#51
Motivation and Context
How Has This Been Tested?
Manual test with OCIS backend (see #3212 for setup)
Manual test with OC 10 backend just in case, also to test the "stime" sorting change which can currently only be tested with OC 10.
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: