[Tests-only] Use ocis-phoenix for running tests in drone #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpakach
force-pushed
the
use-ocis-phoenix-service
branch
3 times, most recently
from
cc6542d to
9f63b75
Compare
dpakach
force-pushed
the
use-ocis-phoenix-service
branch
from
9f63b75 to
2c22126
Compare
dpakach
requested review from
individual-it,
kiranparajuli589 and
haribhandari07
dpakach
added
Status:Needs-Review
| @@ -1046,8 +1047,7 @@ def ocisServices(): | |||
| }, | |||
| 'commands': [ | |||
| 'cd /var/www/owncloud', | |||
| './ocis devldap &', | |||
There was a problem hiding this comment.
should that be deleted too?
There was a problem hiding this comment.
yes, that should not have been there in the first place.
| @@ -89,6 +89,7 @@ config = { | |||
| }, | |||
| 'runningOnOCIS': True, | |||
| 'filterTags': 'not @skip and not @skipOnOCIS', | |||
| 'screenShots': True, | |||
There was a problem hiding this comment.
debug or do we need the screenshots for longterm?
There was a problem hiding this comment.
I think we can leave it for now, will be helpful as soon as tests fail in ocis.
individual-it
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In CI right now we use the ocis binary to run phoenix service for acceptance tests. This PR changes that to ocis-phoenix binary so that we can catch error even earlier.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: