Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for releasing Phoenix assets #3186

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Add docs for releasing Phoenix assets #3186

merged 2 commits into from
Jul 13, 2020

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Mar 16, 2020

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@micbar micbar requested review from PVince81 and LukasHirt March 16, 2020 16:41
@micbar micbar requested a review from DeepDiver1975 as a code owner March 16, 2020 16:41
@micbar micbar self-assigned this Mar 16, 2020
@update-docs
Copy link

update-docs bot commented Mar 16, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar force-pushed the add-release-docs branch from a6c42fc to af5cf92 Compare March 16, 2020 16:43
micbar
micbar commented Apr 20, 2020
View reviewed changes
docs/releasing.md Outdated
4. Update the go module `ocis-pkg` to the latest version <https://blog.golang.org/using-go-modules> .
5. Update the phoenix asset in the Makefile.
6. Run `go generate`.
7. Create Changelog item for the Update in the `$major.$minor.$patchVersion_YYYY-MM-DD` folder.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make generate

@micbar
Copy link
Contributor Author

micbar commented Apr 20, 2020

@PVince81 @LukasHirt This is laying around some time now.

Can you give Feedback?

@LukasHirt
Copy link
Collaborator

Looks nice, just thinking though if the docs is the right place for this. Since the releases will be anyway done by the team and it's more a process then maybe would handbook be a better location?

^ Not saying it should be like that, just asking 😉

LukasHirt
LukasHirt reviewed Apr 21, 2020
View reviewed changes
docs/releasing.md Outdated
3. Move all changelog items from the `changelog/unreleased/` folder to the `$major.$minor.$patchVersion_YYYY-MM-DD` folder.
4. Commit your changes.
5. After merging, wait for the CI to run on the merge commit.
6. Go to "Releases" in GH click "Draft a new Release".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "and" before click?

@PVince81 PVince81 mentioned this pull request May 20, 2020
Merged
PVince81
PVince81 reviewed May 20, 2020
View reviewed changes
docs/releasing.md Outdated
2. Create a Folder in `changelog` for the release version and date `mkdir $major.$minor.$patchVersion_YYYY-MM-DD`.
3. Move all changelog items from the `changelog/unreleased/` folder to the `$major.$minor.$patchVersion_YYYY-MM-DD` folder.
4. Update the go module `ocis-pkg` to the latest version <https://blog.golang.org/using-go-modules> .
5. Update the phoenix asset in the Makefile.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how ?

PVince81
PVince81 reviewed May 20, 2020
View reviewed changes
docs/releasing.md Outdated
1. Create a branch `release-$version`. in <https://github.com/owncloud/ocis-phoenix>
2. Create a Folder in `changelog` for the release version and date `mkdir $major.$minor.$patchVersion_YYYY-MM-DD`.
3. Move all changelog items from the `changelog/unreleased/` folder to the `$major.$minor.$patchVersion_YYYY-MM-DD` folder.
4. Update the go module `ocis-pkg` to the latest version <https://blog.golang.org/using-go-modules> .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how ? add the command directly

@PVince81
Copy link
Contributor

@micbar can we move this to the repo ocis-phoenix ? we could still link to that page from here

I can take care if you agree

@PVince81
Copy link
Contributor

to clarify: we keep the Phoenix repo related docs here in this PR but move the ocis-phoenix ones to the other repo and link them together

PVince81
PVince81 reviewed May 26, 2020
View reviewed changes
docs/releasing.md Outdated Show resolved Hide resolved
@PVince81 PVince81 mentioned this pull request Jul 10, 2020
Merged
@PVince81
Copy link
Contributor

I've extracted the ocis-phoenix bit into owncloud/ocis-phoenix#71

next up: reducing this PR to the minimum needed for a Phoenix release

@PVince81 PVince81 changed the title [WIP] Add docs for releasing in oCIS Add docs for releasing in oCIS Jul 10, 2020
@PVince81 PVince81 changed the title Add docs for releasing in oCIS Add docs for releasing Phoenix assets Jul 10, 2020
@PVince81
Copy link
Contributor

rebased and adjusted, please review

LukasHirt
LukasHirt approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PVince81 PVince81 merged commit 18852c1 into master Jul 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the add-release-docs branch July 13, 2020 11:48
ownclouders pushed a commit that referenced this pull request Jul 13, 2020
commit 18852c1
0952659 
Merge: 5d5e261 a0ccb3c
Author: Vincent Petry <[email protected]>
Date:   Mon Jul 13 13:48:14 2020 +0200

    Merge pull request #3186 from owncloud/add-release-docs

    Add docs for releasing Phoenix assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 left review comments

@LukasHirt LukasHirt LukasHirt approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@micbar micbar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micbar @LukasHirt @PVince81