Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more babel plugins #3173

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Added more babel plugins #3173

merged 1 commit into from
Mar 26, 2020

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Mar 11, 2020

Description

Added babel plugins for optional chaining and nullish coalescing operator and stopped importing core-js directly into the core.

@LukasHirt LukasHirt added the Status:Needs-Review Needs review from a maintainer label Mar 11, 2020
@LukasHirt LukasHirt requested a review from PVince81 March 11, 2020 12:30
@LukasHirt LukasHirt self-assigned this Mar 11, 2020
@update-docs
Copy link

update-docs bot commented Mar 11, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@LukasHirt
Copy link
Collaborator Author

I guess here it doesn't make sense to include changelog item, does it?

@LukasHirt LukasHirt force-pushed the extend-babel-plugins branch from d479864 to 4983fb6 Compare March 11, 2020 16:37
@PVince81
Copy link
Contributor

@LukasHirt if this strips down the release bundle I think it might be worth mentionning as it could decrease loading times and save mobile bandwidth :-)

@LukasHirt LukasHirt force-pushed the extend-babel-plugins branch from 4983fb6 to 42e9673 Compare March 16, 2020 15:40
@LukasHirt
Copy link
Collaborator Author

@PVince81 Changelog added.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LukasHirt LukasHirt force-pushed the extend-babel-plugins branch 2 times, most recently from ba3d984 to befcb7a Compare March 23, 2020 14:45
@PVince81
Copy link
Contributor

please fix conflict then merge :-)

@LukasHirt LukasHirt force-pushed the extend-babel-plugins branch from befcb7a to dffab69 Compare March 25, 2020 22:53
@LukasHirt LukasHirt merged commit eee4627 into master Mar 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the extend-babel-plugins branch March 26, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants