Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved sidebar navigation under top bar #3077

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Moved sidebar navigation under top bar #3077

merged 1 commit into from
Feb 27, 2020

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Feb 21, 2020 •
edited
Loading

How Has This Been Tested?

  • test environment: Manually

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Type:Design Status:Needs-Review Needs review from a maintainer labels Feb 21, 2020
@LukasHirt LukasHirt requested a review from PVince81 February 21, 2020 14:09
@LukasHirt LukasHirt self-assigned this Feb 21, 2020
@LukasHirt
Copy link
Collaborator Author

Styles improving padding and text-transform will come with the next release of ODS.

@LukasHirt LukasHirt force-pushed the feature/improved-nav branch from aa58991 to 2fa661d Compare February 21, 2020 14:10
@PVince81
Copy link
Contributor

can you rebase to get the ODS update ?

@PVince81
Copy link
Contributor

@LukasHirt can you rebase and update the screenshot ?

@LukasHirt
Copy link
Collaborator Author

@PVince81 Sure, will do

@LukasHirt LukasHirt force-pushed the feature/improved-nav branch from 2fa661d to 98e4f51 Compare February 27, 2020 13:37
@LukasHirt
Copy link
Collaborator Author

@PVince81 Rebased and updated screenshot

@PVince81
Copy link
Contributor

screenshot still has capitalized entries ?

@PVince81
Copy link
Contributor

Tested, looks fine

PVince81
PVince81 approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit fcd0b40 into master Feb 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/improved-nav branch February 27, 2020 17:39
@LukasHirt
Copy link
Collaborator Author

Agh must have had some confusion in versions locally... Thanks a lot for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer Type:Design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasHirt @PVince81