Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-only] addressing issue 3055 #3059

Merged
merged 1 commit into from
Feb 19, 2020
Merged

[Tests-only] addressing issue 3055 #3059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/acceptance/features/webUICreateFilesFolders/createFile.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ Feature: create files

Scenario: try to create a file that already exists
When the user tries to create a file with already existing name "lorem.txt" using the webUI
Then an error message "lorem.txt already exists" should be visible
Then the error message "lorem.txt already exists" should be displayed on the webUI dialog prompt
And the create file button should be disabled
10 changes: 0 additions & 10 deletions tests/acceptance/pageObjects/filesPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,12 +269,6 @@ module.exports = {
.waitForElementVisible('@newFileInput')
.setValue('@newFileInput', fileName)
},
waitForErrorMessage: function (callback) {
return this.waitForElementVisible('@fileAlreadyExistAlert')
.getText('@fileAlreadyExistAlert', result => {
return callback(result.value)
})
},
checkForButtonDisabled: function () {
return this.waitForElementVisible('@createFileOkButtonDisabled')
},
Expand Down Expand Up @@ -342,10 +336,6 @@ module.exports = {
selector: "//div[@id='new-file-dialog']//span[contains(text(),'Ok')]",
locateStrategy: 'xpath'
},
fileAlreadyExistAlert: {
selector: "//div[@id='new-file-dialog']//div[contains(@class, 'alert-danger')]",
locateStrategy: 'xpath'
},
permalinkCopyButton: {
selector: '#files-permalink-copy'
},
Expand Down
6 changes: 0 additions & 6 deletions tests/acceptance/stepDefinitions/filesContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,12 +796,6 @@ When('the user tries to create a file with already existing name {string} using
return client.page.filesPage().triesToCreateExistingFile(fileName)
})

Then('an error message {string} should be visible', function (errorMessage) {
return client.page.filesPage().waitForErrorMessage((exactErrorMessage) => {
assert.strictEqual(errorMessage, exactErrorMessage)
})
})

Then('the create file button should be disabled', function () {
return client.page.filesPage().checkForButtonDisabled()
})
Expand Down