Display decimals only for MB and higher #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
added
Category:Enhancement
LukasHirt
force-pushed
the
feature/size-column
branch
from
01e01f4 to
f67763b
Compare
PVince81
reviewed
Feb 19, 2020
|
|
||
| const mb = 1048576 | ||
|
|
||
| // TODO: Pass current language as locale to display correct separator |
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NumberFormat
not sure if quickly doable ?
There was a problem hiding this comment.
please raise issue to address this
There was a problem hiding this comment.
Filesize supports locale on its own - https://www.npmjs.com/package/filesize
This is more about figuring out a nice way to get there the locale.
There was a problem hiding this comment.
Issue raised - #3067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display decimals in resource size column only for MBs or higher and display only once decimal instead of two.
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: