[Tests-Only] Restore files and folder from trashbin with same name #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swoichha please always prefix the subject with "Tests" or something that makes it clear that the PR is about adding tests, not actually implementing the feature. Thanks! |
kiranparajuli589
requested review from
kiranparajuli589
and removed request for
DeepDiver1975
kiranparajuli589
added
Status:Needs-Review
swoichha
changed the title
kiranparajuli589
changed the title
individual-it
requested changes
Feb 13, 2020
There was a problem hiding this comment.
no need to have the extra folder functions, you can use the same as for files. files/folders are the same
e.g. Then('file/folder {string} should be listed on the webUI', function (folder) { is the same as Then('the folder {string} should be listed on the webUI', function (folder) {
tests/acceptance/features/webUITrashbin/trashbinRestore.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/webUITrashbin/trashbinRestore.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/webUITrashbin/trashbinRestore.feature
Outdated
Show resolved
Hide resolved
kiranparajuli589
suggested changes
Feb 13, 2020
tests/acceptance/features/webUITrashbin/trashbinRestore.feature
Outdated
Show resolved
Hide resolved
swoichha
force-pushed
the
trashBinRestoreForFilesAndFolder
branch
from
a3465e2 to
c3f1dd2
Compare
individual-it
requested changes
Feb 14, 2020
individual-it
requested changes
Feb 14, 2020
individual-it
requested changes
Feb 14, 2020
swoichha
force-pushed
the
trashBinRestoreForFilesAndFolder
branch
from
c3f1dd2 to
3052239
Compare
phil-davis
reviewed
Feb 17, 2020
tests/acceptance/features/webUITrashbin/trashbinRestore.feature
Outdated
Show resolved
Hide resolved
kiranparajuli589
suggested changes
Feb 17, 2020
tests/acceptance/features/webUITrashbin/trashbinRestore.feature
Outdated
Show resolved
Hide resolved
kiranparajuli589
previously requested changes
Feb 17, 2020
swoichha
force-pushed
the
trashBinRestoreForFilesAndFolder
branch
from
01f0ace to
cea007b
Compare
individual-it
requested changes
Feb 17, 2020
swoichha
force-pushed
the
trashBinRestoreForFilesAndFolder
branch
from
d732f3a to
fb6fd97
Compare
|
@individual-it @kiranparajuli589 please review again |
|
LGTM 👍 |
individual-it
requested changes
Feb 19, 2020
| @@ -371,6 +378,13 @@ Then('file/folder {string} should not be listed on the webUI', async function (f | |||
| ) | |||
| }) | |||
|
|
|||
| Then('{string} {string} should not be listed on the webUI', async (elementType, folder) => { | |||
There was a problem hiding this comment.
I think that will be too confusing to have a very similar step one with quotes around "folder" and one without.
Better to have separate step for file and folder
individual-it
requested changes
Feb 19, 2020
swoichha
force-pushed
the
trashBinRestoreForFilesAndFolder
branch
from
c8c6abc to
2400e36
Compare
individual-it
approved these changes
Feb 19, 2020
individual-it
dismissed
kiranparajuli589’s stale review
requested changes have been implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#1723
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: