Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File actions now always appear in dropdown form #2974

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Feb 5, 2020

Description

Removed the inline file action buttons, they are now always available
under the three dots button.

Related Issue

Fixes https://github.com/owncloud/enterprise/issues/3740

Motivation and Context

How Has This Been Tested?

Manual test in regular and responsive mode: the three dots button still works.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • changelog

@PVince81 PVince81 requested a review from kulmann February 5, 2020 14:47
@PVince81 PVince81 self-assigned this Feb 5, 2020
@update-docs
Copy link

update-docs bot commented Feb 5, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@PVince81 PVince81 force-pushed the file-actions-collapsed branch from 2530002 to 93866b7 Compare February 5, 2020 14:49
@PVince81 PVince81 marked this pull request as ready for review February 5, 2020 14:49
@PVince81 PVince81 force-pushed the file-actions-collapsed branch from 93866b7 to 0a3e1d1 Compare February 5, 2020 20:07
@PVince81
Copy link
Contributor Author

PVince81 commented Feb 5, 2020

Fixed the test failures and squashed, the way to detect disabled actions in the dropdown is different: in the dropdown the action is simply not present instead of being a disabled button.

@PVince81 PVince81 requested a review from LukasHirt February 5, 2020 21:31
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one minor CR regarding tests.

The impression of the table column header ("Actions") is somewhat funny now, since there is only one action visible in the table (of course more when clicking it). Only change I can think of is, to relabel it to "More" / "Mehr"... maybe ask PM about it 🤔

tests/acceptance/pageObjects/FilesPageElement/filesList.js Outdated Show resolved Hide resolved
Removed the inline file action buttons, they are now always available
under the three dots button.
@PVince81 PVince81 force-pushed the file-actions-collapsed branch from 0a3e1d1 to 605e9ca Compare February 6, 2020 09:14
@PVince81
Copy link
Contributor Author

PVince81 commented Feb 6, 2020

@kulmann thanks for the review. I changed the label to "More" and added a small margin to add some distance with the scrollbar.
Also added the class.

@PVince81 PVince81 merged commit 6729273 into master Feb 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the file-actions-collapsed branch February 6, 2020 11:57
@PVince81
Copy link
Contributor Author

regression: #2998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants