-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display indirect shares for links #2932
Conversation
62f785d
to
b4f290f
Compare
The feature works now and the tests pass. However the styling isn't looking good, we have the "via" link alignment problem here as well. |
Public link shares from parent resources are now shown in the public link share panel with a "via" link to jump to the parent resource.
b4f290f
to
390b149
Compare
@kulmann apart from the styling I think the PR would be ready, CI has passed last time and I've just rebased. Please review the current code. If you have time, can you take care of adjusting the styling like you did for collaborators, maybe with the table ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed some minor issues myself
- added a commit for proper list item styling when having via-links
- moved list items in a separate component to avoid code duplication
duplication and fix styling of indirect link shares.
f854fc9
to
fc55d87
Compare
Intention is to make copy to clipboard, which is visible for direct and indirect link shares, the rightmost button, so that the alignment is correct.
After refactoring the file list item into PublicLinkListItem, the method formDateFromNow was not accessible any more as it was present in the mixin from the original component. This fix adds the mixing to PublicLinkListItem to make that function work again and fixes the issue where links that have an expiration date set would not be shown.
last commits from @kulmann are ok 👍 |
Description
Display indirect link shares in the links panel when link shares exist on any parent resource.
Related Issue
Fixes #2897
(the PR is based on top of the two PRs)
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: