Fix avatar spinner size #2927
Fix avatar spinner size #2927
Conversation
PVince81
force-pushed
the
fix-avatar-loading-duplicate-code
branch
from
6584cbf to
5a1fd3f
Compare
There was a problem hiding this comment.
I don't like the new loading delay behaviour. When an Avatar get's rendered, it shows nothing but the loading spinner and after 5 seconds (timeout in Avatar component) the placeholder with the colored background and one capitalized letter in the center gets displayed. The impression is that the UI is not very responsive/fast. Would be better, to show the placeholder from the start and - without a loading spinner - replace it with the avatar image as soon as it's loaded. In my opinion this doesn't need a visual loading state.
|
The approach to have and use only one, globally available, avatar component is both good and useful. 🚀 |
PVince81
force-pushed
the
fix-avatar-loading-duplicate-code
branch
from
5a1fd3f to
967b1da
Compare
| <oc-icon v-if="item.value.shareType === 1" class="uk-margin-small-right" name="group" size="large" /> | ||
| <oc-icon v-else class="uk-margin-small-right" name="person" size="large" /> | ||
| </template> | ||
| <oc-icon v-if="item.value.shareType === shareTypes.group" class="uk-margin-small-right" name="group" size="large" /> |
There was a problem hiding this comment.
Add key to v-if, v-else
| <div v-else key="collaborator-avatar-placeholder"> | ||
| <oc-icon v-if="collaborator.info.share_type === '1'" class="uk-margin-small-right" name="group" size="large" /> | ||
| <oc-icon v-if="$_shareType === shareTypes.group" class="uk-margin-small-right" name="group" size="large" /> |
There was a problem hiding this comment.
Add key to v-if, v-else
src/components/Avatar.vue
Outdated
| @@ -1,12 +1,15 @@ | |||
| <template> | |||
| <component :is="type" v-if="enabled"> | |||
| <oc-avatar :width="width" :loading="loading" :src="avatarSource" :userName="userName" /> | |||
| <oc-spinner v-if="loading" size="small" key="collaborator-avatar-spinner" :aria-label="$gettext('Loading')" | |||
There was a problem hiding this comment.
Add key to v-if, v-else
PVince81
force-pushed
the
fix-avatar-loading-duplicate-code
branch
from
967b1da to
690fb30
Compare
|
@LukasHirt I've added the requested keys, please recheck |
|
and I forgot the changelog entry as this is a bugfix |
Refactored avatar component logic to be located only in Phoenix core. Moved spinner into the avatar component. Adjusted spinner size to match the one of the avatar to avoid layout shifting.
PVince81
force-pushed
the
fix-avatar-loading-duplicate-code
branch
from
690fb30 to
5df30e4
Compare
delete-merged-branch
bot
deleted the
fix-avatar-loading-duplicate-code
branch
Description
Refactored avatar component logic to be located only in Phoenix core.
Moved spinner into the avatar component.
Adjusted spinner size to match the one of the avatar to avoid layout shifting
Related Issue
Fix #2921
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: