Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty parentheses in shared with others list #2725

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Remove empty parentheses in shared with others list #2725

merged 1 commit into from
Dec 17, 2019

Conversation

LukasHirt
Copy link
Collaborator

Description

If the shared with an entry is not group, hide parentheses

Related Issue

How Has This Been Tested?

  • test environment: Manually
  • test case 1: Share item with user
  • test case 2: Share item with group

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt self-assigned this Dec 17, 2019
PVince81
PVince81 approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit d78bc0f into master Dec 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/shared-with-parentheses branch December 17, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@LukasHirt LukasHirt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Shared With" Column shows empty parentheses
2 participants
@LukasHirt @PVince81