Selecting breadcrumb and reloading inside problematic folder #2530

haribhandari07 · 2019-11-22T09:24:04Z

Description

Browsing inside problematic folder that contains %2F for eg folder%2Fwith%2FSlashes and then clicking on breadcrumb displays error message. This PR verifies this issue: #1883

Related Issue

#1883

Motivation and Context

How Has This Been Tested?

Manual
CI

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

ownclouders · 2019-11-22T10:19:56Z

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6679/

tests/acceptance/stepDefinitions/filesContext.js

tests/acceptance/pageObjects/filesPage.js

tests/acceptance/features/webUIFiles/createFolderEdgeCases.feature

dpakach

LGTM 👍

ownclouders · 2019-11-22T12:25:20Z

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6697/

skshetry · 2019-11-25T04:26:30Z

tests/acceptance/pageObjects/filesPage.js

+    navigateToBreadcrumb: async function (resource) {
+      const resourceXpath = util.format(this.elements.resourceBreadcrumb.selector, resource)
+      return this
+        .useXpath()


Suggested change

.useXpath()

.useStrategy(this.elements.resourceBreadcrumb)

tests/acceptance/stepDefinitions/filesContext.js

skshetry · 2019-11-25T04:28:26Z

tests/acceptance/pageObjects/filesPage.js

+     *
+     * @param {string} resource
+     */
+    navigateToBreadcrumb: async function (resource) {


Suggested change

navigateToBreadcrumb: async function (resource) {

navigateToBreadcrumb: function (resource) {

skshetry

Looks good. Please squash all the commits.

ownclouders · 2019-11-25T06:28:36Z

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6723/

haribhandari07 · 2019-11-27T05:37:04Z

rootFolder: "" is set in drone, so breadcrumb is not seen one level below the root folder. So, this PR is currently blocked and will be available after PR #2540 is merged.

PVince81 · 2019-11-29T12:12:35Z

looks like #2540 was merged already

ownclouders · 2019-12-02T06:24:34Z

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6908/

dpakach · 2019-12-02T08:16:23Z

tests/acceptance/features/webUIFiles/breadcrumb.feature

@@ -8,7 +8,7 @@ Feature: access breadcrumb

  @issue-2538
  Scenario: Check breadCrumb for folder one level below the root folder when rootFolder is set
-    Given the rootFolder has been set to "" in phoenix config file
+    Given the "rootFolder" has been set to "" in phoenix config file


Suggested change

Given the "rootFolder" has been set to "" in phoenix config file

Given the property "rootFolder" has been set to "" in phoenix config file

I think this sounds better.

stale review

dpakach

LGTM 👍

ownclouders · 2019-12-02T09:27:31Z

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6917/

ownclouders · 2019-12-02T10:53:58Z

💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6931/

individual-it

small change request

@PVince81 in #2540 the test were focused on the rootFolder setting, here its more about the special character %2F in the folder name

individual-it · 2019-12-04T04:11:05Z

tests/acceptance/features/webUIFiles/breadcrumb.feature

+    When the user opens folder "folder%2Fwith%2FSlashes" using the webUI
+    And the user browses to folder "folder%2Fwith%2FSlashes" using the breadcrumb on the webUI
+    Then the error message "Loading folder failed…" should be displayed on the webUI
+    # Then the error message should not be displayed on the webUI


we already have a step for that

Suggested change

# Then the error message should not be displayed on the webUI

# Then no message should be displayed on the webUI

haribhandari07 force-pushed the click-breadcrumbs branch from fde1c67 to 31532dc Compare November 22, 2019 09:32

haribhandari07 marked this pull request as ready for review November 22, 2019 09:32

haribhandari07 requested a review from DeepDiver1975 as a code owner November 22, 2019 09:32

haribhandari07 self-assigned this Nov 22, 2019

haribhandari07 added Status:Needs-Review Needs review from a maintainer dev:acceptance-tests labels Nov 22, 2019

haribhandari07 requested review from skshetry and dpakach November 22, 2019 09:33

haribhandari07 force-pushed the click-breadcrumbs branch from 31532dc to f6426bd Compare November 22, 2019 10:39

dpakach reviewed Nov 22, 2019

View reviewed changes

tests/acceptance/stepDefinitions/filesContext.js Outdated Show resolved Hide resolved

dpakach reviewed Nov 22, 2019

View reviewed changes

tests/acceptance/pageObjects/filesPage.js Outdated Show resolved Hide resolved

dpakach reviewed Nov 22, 2019

View reviewed changes

tests/acceptance/features/webUIFiles/createFolderEdgeCases.feature Outdated Show resolved Hide resolved

haribhandari07 force-pushed the click-breadcrumbs branch from f6426bd to 20cf779 Compare November 22, 2019 11:03

haribhandari07 requested a review from dpakach November 22, 2019 11:04

dpakach reviewed Nov 22, 2019

View reviewed changes

skshetry reviewed Nov 25, 2019

View reviewed changes

tests/acceptance/stepDefinitions/filesContext.js Show resolved Hide resolved

skshetry reviewed Nov 25, 2019

View reviewed changes

skshetry previously approved these changes Nov 25, 2019

View reviewed changes

haribhandari07 force-pushed the click-breadcrumbs branch from 89a741a to 87670b0 Compare December 2, 2019 05:42

haribhandari07 requested review from dpakach and skshetry December 2, 2019 05:43

haribhandari07 force-pushed the click-breadcrumbs branch from 87670b0 to 8612ef9 Compare December 2, 2019 06:52

haribhandari07 requested a review from kiranparajuli589 December 2, 2019 08:06

haribhandari07 requested a review from jasson99 December 2, 2019 08:06

dpakach reviewed Dec 2, 2019

View reviewed changes

haribhandari07 force-pushed the click-breadcrumbs branch from 8612ef9 to 9b3fa81 Compare December 2, 2019 08:34

haribhandari07 requested a review from dpakach December 2, 2019 08:52

dpakach reviewed Dec 2, 2019

View reviewed changes

haribhandari07 requested a review from individual-it December 2, 2019 09:19

haribhandari07 force-pushed the click-breadcrumbs branch from 9b3fa81 to 7922660 Compare December 2, 2019 10:22

individual-it requested changes Dec 4, 2019

View reviewed changes

Selecting breadcrumb and reloading inside problematic folder

c7a91e4

haribhandari07 force-pushed the click-breadcrumbs branch from 7922660 to c7a91e4 Compare December 4, 2019 06:11

haribhandari07 requested a review from individual-it December 4, 2019 06:12

individual-it approved these changes Dec 4, 2019

View reviewed changes

haribhandari07 merged commit 5fcb379 into master Dec 4, 2019

delete-merged-branch bot deleted the click-breadcrumbs branch December 4, 2019 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Selecting breadcrumb and reloading inside problematic folder #2530

Selecting breadcrumb and reloading inside problematic folder #2530

haribhandari07 commented Nov 22, 2019 •

edited

Loading

ownclouders commented Nov 22, 2019

dpakach left a comment

ownclouders commented Nov 22, 2019

skshetry Nov 25, 2019 •

edited

Loading

skshetry Nov 25, 2019

skshetry left a comment

ownclouders commented Nov 25, 2019

haribhandari07 commented Nov 27, 2019 •

edited

Loading

PVince81 commented Nov 29, 2019

ownclouders commented Dec 2, 2019

dpakach Dec 2, 2019

dpakach left a comment

ownclouders commented Dec 2, 2019

ownclouders commented Dec 2, 2019

individual-it left a comment

individual-it Dec 4, 2019

	navigateToBreadcrumb: async function (resource) {
	navigateToBreadcrumb: function (resource) {

	Given the "rootFolder" has been set to "" in phoenix config file
	Given the property "rootFolder" has been set to "" in phoenix config file

	# Then the error message should not be displayed on the webUI
	# Then no message should be displayed on the webUI

Selecting breadcrumb and reloading inside problematic folder #2530

Selecting breadcrumb and reloading inside problematic folder #2530

Conversation

haribhandari07 commented Nov 22, 2019 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

ownclouders commented Nov 22, 2019

dpakach left a comment

Choose a reason for hiding this comment

ownclouders commented Nov 22, 2019

skshetry Nov 25, 2019 • edited Loading

Choose a reason for hiding this comment

skshetry Nov 25, 2019

Choose a reason for hiding this comment

skshetry left a comment

Choose a reason for hiding this comment

ownclouders commented Nov 25, 2019

haribhandari07 commented Nov 27, 2019 • edited Loading

PVince81 commented Nov 29, 2019

ownclouders commented Dec 2, 2019

dpakach Dec 2, 2019

Choose a reason for hiding this comment

dpakach left a comment

Choose a reason for hiding this comment

ownclouders commented Dec 2, 2019

ownclouders commented Dec 2, 2019

individual-it left a comment

Choose a reason for hiding this comment

individual-it Dec 4, 2019

Choose a reason for hiding this comment

haribhandari07 commented Nov 22, 2019 •

edited

Loading

skshetry Nov 25, 2019 •

edited

Loading

haribhandari07 commented Nov 27, 2019 •

edited

Loading