Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry clicking on delete confirmation popup #2417

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Retry clicking on delete confirmation popup #2417

merged 2 commits into from
Nov 12, 2019

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Nov 8, 2019 •
edited
Loading

Description

This PR handles retrying to click the popup dialog which has been failing quite a lot.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally, and CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@skshetry skshetry self-assigned this Nov 8, 2019
@skshetry skshetry force-pushed the retry-click-deletion-dialog branch from bb9a83c to 9601bb9 Compare November 11, 2019 04:56
@skshetry skshetry marked this pull request as ready for review November 11, 2019 04:56
@skshetry skshetry force-pushed the retry-click-deletion-dialog branch from 9601bb9 to 0c5ad8b Compare November 11, 2019 05:02
dpakach
dpakach reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis phil-davis added Status:Needs-release and removed Status:Needs-Review Needs review from a maintainer labels Nov 11, 2019
@haribhandari07
Copy link
Contributor

LGTM

@skshetry
Copy link
Member Author

Drone is broken. :(

@skshetry skshetry mentioned this pull request Nov 11, 2019
Closed
@phil-davis
Copy link
Contributor

Drone is back. I restarted the job.

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6314/

20191111-093639-921.png

@phil-davis
Copy link
Contributor

Restarted drone again

@skshetry
Copy link
Member Author

This won't pass without merging #2425.

@phil-davis phil-davis force-pushed the retry-click-deletion-dialog branch from d49bc62 to 19b0f79 Compare November 12, 2019 01:19
@phil-davis
Copy link
Contributor

I rebased this PR, and chery-picked the fix from #2425
Hopefully CI will pass with both of these together.

@phil-davis phil-davis mentioned this pull request Nov 12, 2019
Closed
@skshetry skshetry merged commit 7d9e042 into master Nov 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the retry-click-deletion-dialog branch November 12, 2019 08:50
This was referenced Nov 12, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpakach dpakach dpakach left review comments

@phil-davis phil-davis phil-davis approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

Assignees

@skshetry skshetry

Labels
QA:team Status:Needs-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skshetry @haribhandari07 @phil-davis @ownclouders @dpakach