Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PQueue to run only one create folder promise in folder upload #2210

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

LukasHirt
Copy link
Collaborator

Description

Use PQueue to run only one create folder promise in folder upload so that parent folder can be created before the children.

How Has This Been Tested?

  • test environment: Manually
  1. Upload folder with subfolder

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer bug-solved labels Oct 10, 2019
@LukasHirt LukasHirt self-assigned this Oct 10, 2019
@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Oct 10, 2019

In case the nested folder structure holds files with the same name there is a warning i the browser console.

Screenshot from 2019-10-10 16-24-04
Screenshot from 2019-10-10 16-25-27

@DeepDiver1975
Copy link
Member

I did not properly see if this has an impact on the upload list - but given the warning and code location I suspect that the list will not properly be populated

@LukasHirt

Use unique id for item key
@LukasHirt LukasHirt force-pushed the bugfix/folder-upload-queue branch from 8dbadff to 22673e4 Compare October 10, 2019 14:51
@LukasHirt
Copy link
Collaborator Author

@DeepDiver1975 Added unique id and used it as a key. Error is gone now 😉

@DeepDiver1975 DeepDiver1975 merged commit eeb651b into master Oct 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/folder-upload-queue branch October 10, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants