Fix password handling in public links #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixheidecke
added
Type:Bug
PVince81
reviewed
Oct 8, 2019
| <input type="password" autocomplete="new-password" class="uk-input" :class="{ 'uk-form-danger': !$_passwordIsValid }" v-model="password" :placeholder="hasPassword && password === null? '********' : placeholder.password" id="oc-files-file-link-password" /> | ||
| <div class="uk-position-relative"> | ||
| <input type="password" autocomplete="new-password" class="uk-input" :class="{ 'uk-form-danger': !$_passwordIsValid }" v-model="password" :placeholder="hasPassword && password === null? '********' : placeholder.password" id="oc-files-file-link-password" /> | ||
| <div uk-close v-if="!$_passwordEnforced && hasPassword && password!=''" class="uk-position-small uk-position-center-right oc-cursor-pointer" @click="password=''" :uk-tooltip="$_passwordRemoveText" /> |
There was a problem hiding this comment.
seems the _passwordEnforced condition does not do anything.
I tried enforcing password only for the "Editor" role and the cross was still visible to discard the password.
Maybe the _passwordEnforced function is not working ? As I can see it's not using proper bitmasks...
|
Tested, all works except for the password enforced bit. Still, even without that, an error message is properly displayed in case I try to save a link without password while password is enforced. So merging this even without the check would be fine by me for now... |
PVince81
approved these changes
Oct 10, 2019
delete-merged-branch
bot
deleted the
bugfix/conditional-icon-rendering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
See issues
How Has This Been Tested?
Manual test
Types of changes
Checklist: