Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logout step for acceptance tests #2100

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Conversation

PVince81
Copy link
Contributor

Description

Added logout step.
Added logout test case that includes the step and checks that the login
page appears after logging out.

Related Issue

Motivation and Context

Needed to be able to log out in some test cases, especially the public link ones.

How Has This Been Tested?

  • manual run

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PVince81
Copy link
Contributor Author

@individual-it I need help here: for some reason it does not click on the menu button. In VNC I see that the menu did not open.

Still, I see many other test cases that use the same approach for the menu using the phoenixPage.navigateToUsingMenu() method from which I borrowed the approach.

I don't get why the menu doesn't open in my case. Am I using the page object in the wrong place ?

@PVince81 PVince81 mentioned this pull request Sep 30, 2019
9 tasks
@PVince81
Copy link
Contributor Author

This PR is required to be able to properly write public link tests for #1951

@PVince81 PVince81 self-assigned this Sep 30, 2019
@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Sep 30, 2019
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUILogin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5314/

20190930-133328-122.png
20190930-133353-112.png

@PVince81
Copy link
Contributor Author

PVince81 commented Oct 1, 2019

solved: I forgot to return the promise

@PVince81 PVince81 marked this pull request as ready for review October 1, 2019 07:52
@PVince81 PVince81 added Status:Needs-Review Needs review from a maintainer and removed Status:In-Progress labels Oct 1, 2019
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5336/

20191001-080341-597.png
20191001-080406-055.png
20191001-080406-371.png

Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logout test itself is good, for the the public link test I would suggest to make the creation of the public link a Given step that is executed using the API and then there is no problem with the logout

@PVince81
Copy link
Contributor Author

PVince81 commented Oct 1, 2019

@individual-it oops, I didn't intend to checkin the public link test here. I'll remove.

Added logout step.
Added logout test case that includes the step and checks that the login
page appears after logging out.
@PVince81
Copy link
Contributor Author

PVince81 commented Oct 1, 2019

@individual-it removed share test, please approve

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5347/

20191001-090312-945.png
20191001-090313-272.png
20191001-090343-245.png
20191001-090417-249.png

@PVince81 PVince81 merged commit 5b65bb3 into master Oct 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the tests-logout-step branch October 1, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants