-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logout step for acceptance tests #2100
Conversation
@individual-it I need help here: for some reason it does not click on the menu button. In VNC I see that the menu did not open. Still, I see many other test cases that use the same approach for the menu using the I don't get why the menu doesn't open in my case. Am I using the page object in the wrong place ? |
This PR is required to be able to properly write public link tests for #1951 |
💥 Acceptance tests webUILogin failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/5314/
|
addfd6d
to
cd4ede1
Compare
solved: I forgot to |
💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/5336/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logout test itself is good, for the the public link test I would suggest to make the creation of the public link a Given
step that is executed using the API and then there is no problem with the logout
@individual-it oops, I didn't intend to checkin the public link test here. I'll remove. |
Added logout step. Added logout test case that includes the step and checks that the login page appears after logging out.
cd4ede1
to
874e8ae
Compare
@individual-it removed share test, please approve |
💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/5347/
|
Description
Added logout step.
Added logout test case that includes the step and checks that the login
page appears after logging out.
Related Issue
Motivation and Context
Needed to be able to log out in some test cases, especially the public link ones.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: