Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/drawio integration #2083

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Sep 27, 2019

Description

First part:

Apps can now define if they want to be opened in their own browser tab including the capability to define the route to be used

Second part:

an integration app for draw.io has been added ass ref implementation

Motivation and Context

  • elaborate on necessary changes to the files app to open up file editors/viewers in a new tab
  • elaborate on capabilities to integrate a 3rd party web server

How Has This Been Tested?

  • create a new file test.drawio
  • click on the file in the files list
  • click on draw.io action
  • see file being opened in a second tab

Note

  • if the same file is opened twice the same tab will be reused
  • a different file will be opened in a different tab

Screenshots (if appropriate):

Screenshot from 2019-09-27 11-15-47
Screenshot from 2019-09-27 11-15-36

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Sep 27, 2019
@DeepDiver1975 DeepDiver1975 self-assigned this Sep 27, 2019
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUILogin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5266/

20190927-153326-518.png
20190927-153343-714.png

@LukasHirt
Copy link
Collaborator

Does it need to be in fullscreen and in new tab? Or was it done only as a prototype to see how it would be possible?

@DeepDiver1975
Copy link
Member Author

Integrations with Feature rich applications have shown in the past years to be best done in new tabs.
I consider this a Major Design principle for Phoenix in the future

@DeepDiver1975 DeepDiver1975 merged commit 0370481 into master Oct 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/drawio-integration branch October 1, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants