Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sharetype keys that are human readable instead of number #2071

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Use sharetype keys that are human readable instead of number #2071

merged 1 commit into from
Sep 25, 2019

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Sep 25, 2019 •
edited
Loading

Description

Use human readable strings instead of number.

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@skshetry skshetry requested a review from dpakach September 25, 2019 03:42
@skshetry skshetry self-assigned this Sep 25, 2019
dpakach
dpakach reviewed Sep 25, 2019
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUILogin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5189/

20190925-041411-444.png
20190925-041428-696.png

@skshetry skshetry merged commit 7ea7208 into master Sep 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the human-readable-sharetype branch September 25, 2019 10:34
@skshetry skshetry added Status:Needs-release and removed Status:Needs-Review Needs review from a maintainer labels Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpakach dpakach dpakach left review comments

@individual-it individual-it individual-it approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@skshetry skshetry

Labels
QA:team Status:Needs-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Acceptance tests: Fix sharing function to use human readable shareType argument
4 participants
@skshetry @ownclouders @individual-it @dpakach