Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File list star is now a button #1958

Closed
wants to merge 1 commit into from
Closed

File list star is now a button #1958

wants to merge 1 commit into from

Conversation

PVince81
Copy link
Contributor

Description

This brings the following benefits:

  • hand mouse cursor on hover
  • readable by accessibility tools

Related Issue

Motivation and Context

Mostly accessibility

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

File list star is now a button
602c7b1 
This brings the following benefits:
- hand mouse cursor on hover
- readable by accessibility tools
@PVince81 PVince81 requested a review from LukasHirt September 12, 2019 10:55
@PVince81 PVince81 self-assigned this Sep 12, 2019
@PVince81 PVince81 mentioned this pull request Sep 12, 2019
Closed
@PVince81
Copy link
Contributor Author

abandoned, likely the wrong approach

@PVince81 PVince81 closed this Dec 12, 2019
@pascalwengerter pascalwengerter deleted the favorite-to-button branch April 26, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

Assignees

@PVince81 PVince81

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Favourite/star is not button
1 participant
@PVince81