Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick workaround: Disable file/folder renaming for all views #1947

Closed
wants to merge 1 commit into from

Conversation

Julian1998
Copy link
Contributor

@Julian1998 Julian1998 commented Sep 10, 2019

Description

Disallow all renames

Related Issue

Motivation and Context

@DeepDiver1975 requested a workaround as described in #1750. There it is :)

How Has This Been Tested?

  • Try to rename a file
  • Rename button should be disabled

Screenshots (if appropriate):

Bildschirmfoto von »2019-09-10 15-55-56«

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@Julian1998 Julian1998 added the Status:Needs-Review Needs review from a maintainer label Sep 10, 2019
@Julian1998 Julian1998 self-assigned this Sep 10, 2019
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFolders failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5052/

20190910-140522-150.png
20190910-140522-422.png
20190910-140522-662.png
20190910-140557-890.png
20190910-140558-236.png
20190910-140558-493.png
20190910-140622-736.png
20190910-140622-991.png
20190910-140623-245.png
20190910-140647-287.png
20190910-140647-504.png
20190910-140647-726.png
20190910-140712-404.png
20190910-140712-659.png
20190910-140712-920.png
20190910-140737-738.png
20190910-140737-966.png
20190910-140738-199.png
20190910-140802-991.png
20190910-140803-234.png
20190910-140803-453.png
20190910-140827-747.png
20190910-140828-002.png
20190910-140828-242.png
20190910-140903-087.png
20190910-140903-337.png
20190910-140903-581.png
20190910-140928-088.png
20190910-140928-326.png
20190910-140928-575.png
20190910-141001-101.png
20190910-141001-342.png
20190910-141001-599.png
20190910-141034-687.png
20190910-141034-929.png
20190910-141035-196.png
20190910-141108-175.png
20190910-141108-422.png
20190910-141108-680.png
20190910-141132-760.png
20190910-141132-989.png
20190910-141133-243.png
20190910-141157-544.png
20190910-141157-799.png
20190910-141158-116.png
20190910-141222-277.png
20190910-141222-512.png
20190910-141222-746.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5052/

20190910-141827-509.png
20190910-141827-744.png
20190910-141828-042.png
20190910-141857-249.png
20190910-141857-462.png
20190910-141857-833.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5052/

20190910-140845-294.png
20190910-140845-383.png
20190910-140845-456.png
20190910-140906-338.png
20190910-140906-423.png
20190910-140906-538.png
20190910-140927-138.png
20190910-140927-222.png
20190910-140927-308.png
20190910-140948-038.png
20190910-140948-123.png
20190910-140948-206.png
20190910-141008-813.png
20190910-141008-889.png
20190910-141008-978.png
20190910-141029-420.png
20190910-141029-515.png
20190910-141029-604.png
20190910-141050-525.png
20190910-141050-661.png
20190910-141050-738.png
20190910-141111-475.png
20190910-141111-596.png
20190910-141111-691.png
20190910-141132-323.png
20190910-141132-404.png
20190910-141132-489.png
20190910-141202-521.png
20190910-141202-605.png
20190910-141202-679.png
20190910-141224-582.png
20190910-141224-668.png
20190910-141224-757.png
20190910-141245-463.png
20190910-141245-533.png
20190910-141245-618.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5052/

20190910-140750-443.png
20190910-140750-622.png
20190910-140750-806.png
20190910-140812-299.png
20190910-140812-420.png
20190910-140812-604.png
20190910-140833-786.png
20190910-140833-956.png
20190910-140834-102.png
20190910-140856-069.png
20190910-140856-229.png
20190910-140856-382.png
20190910-140918-957.png
20190910-140919-176.png
20190910-140919-304.png
20190910-140941-023.png
20190910-140941-128.png
20190910-140941-336.png
20190910-141002-481.png
20190910-141002-607.png
20190910-141002-745.png
20190910-141042-993.png
20190910-141043-131.png
20190910-141043-240.png
20190910-141104-800.png
20190910-141105-006.png
20190910-141105-150.png
20190910-141136-284.png
20190910-141136-459.png
20190910-141136-627.png
20190910-141158-156.png
20190910-141158-297.png
20190910-141158-477.png
20190910-141219-637.png
20190910-141219-770.png
20190910-141219-904.png
20190910-141933-779.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5052/

20190910-140640-246.png
20190910-140640-555.png
20190910-140640-932.png
20190910-140710-852.png
20190910-140711-165.png
20190910-140711-517.png
20190910-140738-809.png
20190910-140739-132.png
20190910-140739-374.png
20190910-140816-136.png
20190910-140816-455.png
20190910-140816-663.png
20190910-140842-674.png
20190910-140843-000.png
20190910-140843-243.png
20190910-140909-620.png
20190910-140909-927.png
20190910-140910-244.png
20190910-140946-959.png
20190910-140947-313.png
20190910-140947-577.png
20190910-141017-979.png
20190910-141018-238.png
20190910-141018-494.png
20190910-141055-647.png
20190910-141056-007.png
20190910-141056-273.png
20190910-141134-785.png
20190910-141134-997.png
20190910-141135-321.png
20190910-141201-379.png
20190910-141201-659.png
20190910-141202-041.png
20190910-141229-589.png
20190910-141229-822.png
20190910-141230-248.png
20190910-141258-839.png
20190910-141259-124.png
20190910-141259-456.png
20190910-141327-311.png
20190910-141327-593.png
20190910-141327-886.png
20190910-141355-641.png
20190910-141356-052.png
20190910-141356-358.png
20190910-141424-061.png
20190910-141424-384.png
20190910-141424-755.png
20190910-141452-090.png
20190910-141452-425.png
20190910-141452-716.png
20190910-141520-465.png
20190910-141521-129.png
20190910-141521-528.png
20190910-141558-513.png
20190910-141558-890.png
20190910-141559-202.png
20190910-141627-599.png
20190910-141627-928.png
20190910-141628-164.png
20190910-141703-407.png
20190910-141703-646.png
20190910-141703-863.png
20190910-141729-598.png
20190910-141729-813.png
20190910-141730-213.png
20190910-141756-568.png
20190910-141756-872.png
20190910-141757-091.png
20190910-141822-727.png
20190910-141822-962.png
20190910-141823-229.png
20190910-141859-252.png
20190910-141859-506.png
20190910-141859-906.png
20190910-141934-609.png
20190910-141934-840.png
20190910-141935-077.png
20190910-142001-060.png
20190910-142001-333.png
20190910-142001-613.png
20190910-142046-520.png
20190910-142046-782.png
20190910-142047-040.png
20190910-142113-163.png
20190910-142113-408.png
20190910-142113-671.png
20190910-142139-700.png
20190910-142139-955.png
20190910-142140-246.png
20190910-142206-668.png
20190910-142206-907.png
20190910-142207-182.png
20190910-142232-344.png
20190910-142232-579.png
20190910-142232-863.png
20190910-142258-006.png
20190910-142258-253.png
20190910-142258-514.png
20190910-142323-763.png
20190910-142324-023.png
20190910-142324-265.png
20190910-142349-013.png
20190910-142349-242.png
20190910-142349-478.png
20190910-142414-700.png
20190910-142414-927.png
20190910-142415-177.png
20190910-142440-486.png
20190910-142440-814.png
20190910-142441-082.png
20190910-142506-783.png
20190910-142507-034.png
20190910-142507-293.png

@LukasHirt
Copy link
Collaborator

LukasHirt commented Sep 10, 2019

@Julian1998 Is the related issue right one?

@LukasHirt
Copy link
Collaborator

If it's related to #1750 then disable pls only on favorites view and leave it in the "main" files list.

@Julian1998 Julian1998 force-pushed the fix/disallow-renaming branch from d320aef to 0ae6780 Compare September 17, 2019 07:45
@Julian1998
Copy link
Contributor Author

fixed in ##2129

@Julian1998 Julian1998 closed this Oct 11, 2019
@Julian1998 Julian1998 deleted the fix/disallow-renaming branch October 11, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to rename a file on the favorites page to a name of a file from an other folder
3 participants