Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted access denied template #1940

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Adjusted access denied template #1940

merged 1 commit into from
Sep 9, 2019

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Sep 9, 2019

Description

Added fixed width to footer of access denied page and moved link into p tag to keep it on same line.

Motivation and Context

Without fixed width the footer would expand across the screen create one big line of text - bad. Also when the link was outside the p tag, it was always on its own line + margin bottom was applied.

How Has This Been Tested?

  • test environment: Manually

Screenshots (if appropriate):

localhost_8300_(iPad) (1)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added the Status:Needs-Review Needs review from a maintainer label Sep 9, 2019
@LukasHirt LukasHirt self-assigned this Sep 9, 2019
@LukasHirt LukasHirt force-pushed the bugfix/adjust-helpdesk branch from 62f440b to f3590ec Compare September 9, 2019 14:28
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LukasHirt LukasHirt merged commit a84b29c into master Sep 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/adjust-helpdesk branch September 9, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants