Redirect to private link after log in

[LukasHirt]

Description

If login page is triggered after trying to access private link, url of private link gets saved to store and via vuex-persist is persisted during the redirection to different page due to login. After login is successful the redirect to private link is triggered. During that redirection the private link gets deleted from store to allow normal log in later.

Motivation and Context

When users don't get redirected to private link after login it is not only a bug but also could lead to potential confusion when they'd think they landed into the folder and could start throwing items in there which where supposed to be somewhere else.

How Has This Been Tested?

• test environment: Manually

1. Create a private link for folder
2. Exit Phoenix
3. Enter private link
4. Go through authorisation process
5. Get redirected to the item
6. Copy different private link
7. Enter the private link without exiting Phoenix
8. Get redirected to the item
9. Exit Phoenix
10. Go through authorisation process without private link
11. See normal files list

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[LukasHirt]

This needs to be it's own module due to vuex-persist. Since we are using modules in options we can't use reducer to persist only specific states. This would mean the only option of adding it to existing module would be user module which doesn't seem right to me to contain info about private link.

[ownclouders]

💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4976/

[PVince81]

See comments.

I'm a bit worried about the potential race conditions when multiple browser tabs are opened with different private links, while here we only store a single link. I'm not sure if this is a big concern though, need to evaluate the risk.

Would also be good to know what @DeepDiver1975 thinks here

[PVince81]

also see #1882

not sure if the persistence layer works in incognito mode ?

[LukasHirt]

not sure if the persistence layer works in incognito mode ?

Just tried this - works fine

[ownclouders]

💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4999/

[ownclouders]

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4999/

[ownclouders]

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4999/

[LukasHirt]

I'm a bit worried about the potential race conditions when multiple browser tabs are opened with different private links, while here we only store a single link. I'm not sure if this is a big concern though, need to evaluate the risk.

Maybe session storage could help here - https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage Will do some testing with it.

This would mean then introducing separate vuex-persist logic for the links module though.

[PVince81]

Are there any other alternatives where we could pass the old link around ?
I guess this would mean that we need to support passing the redirect URL through the whole authentication/authorize process ?

[LukasHirt]

Are there any other alternatives where we could pass the old link around ?
I guess this would mean that we need to support passing the redirect URL through the whole authentication/authorize process ?

I think there aren't. Since we leave Phoenix completely due to the authorisation we need to store it in the storage. Other scenarios would lead to losing the link.

[PVince81]

👍