Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added avatars to collaborators list #1811

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Added avatars to collaborators list #1811

merged 1 commit into from
Aug 16, 2019

Conversation

LukasHirt
Copy link
Collaborator

Related Issue

How Has This Been Tested?

  • test environment: manually
  1. Assign avatar to a user
  2. Add collaborator with avatar
  3. Add collaborator without avatar
  4. Add group of collaborators
  5. Delete collaborator which is under another collaborator

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Added avatars to collaborators list
fd5591d 
Changed key to id instead of index
@LukasHirt LukasHirt added Category:Enhancement Add new functionality Status:Needs-Review Needs review from a maintainer labels Aug 16, 2019
@LukasHirt LukasHirt self-assigned this Aug 16, 2019
@DeepDiver1975 DeepDiver1975 merged commit 9787dbc into master Aug 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/collaborators-list-avatars branch August 16, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

Assignees

@LukasHirt LukasHirt

Labels
Category:Enhancement Add new functionality Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasHirt @DeepDiver1975