Fix process of collaborators #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ]), | ||
|
|
||
| onAutocompleteInput (value) { | ||
| if (value.length < 2) { |
There was a problem hiding this comment.
we need to respect the capability here - file_sharing.search_min_length
LukasHirt
force-pushed
the
bugfix/collaborators-process
branch
3 times, most recently
from
82438eb to
a5a3b67
Compare
LukasHirt
added
Status:Needs-Review
LukasHirt
force-pushed
the
bugfix/collaborators-process
branch
from
a5a3b67 to
6bc972e
Compare
| @@ -135,4 +152,8 @@ export default { | |||
| .oc-text { | |||
| font-size: 1rem; | |||
| } | |||
|
|
|||
| .oc-disabled { | |||
There was a problem hiding this comment.
one day we need to move this to ODS ....
There was a problem hiding this comment.
Already working on this 😉
| $_ocCollaborators_loadAvatar (item) { | ||
| const dav = this.$client.helpers._davPath | ||
| const headers = new Headers() | ||
| const url = `${dav}/avatars/${item.value.shareWith}/128.png` |
There was a problem hiding this comment.
image-source .... one day ...
There was a problem hiding this comment.
Not sure if image-source would help here. We will need to show some placeholder images in case the response is 404. AFAIK image-source doesn't handle this. And since it's avatar specific functionality not sure if we want to include it there.
DeepDiver1975
approved these changes
Aug 2, 2019
|
Eslint issue |
LukasHirt
force-pushed
the
bugfix/collaborators-process
branch
from
6bc972e to
644d4e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Grey out other collaborators when add or edit action is in progress, added cancel button to edit and divided code into smaller components.
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: