fix: handle sidebar resizing #12045
Merged
fix: handle sidebar resizing #12045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saw-jan
reviewed
Dec 19, 2024
| const backgroundContentEl = computed(() => { | ||
| return unref(appSideBar)?.parentElement?.querySelector('div') as HTMLElement | ||
| }) | ||
|
|
||
| const onResize = () => { |
There was a problem hiding this comment.
maybe we can think of debouncing the function.
There was a problem hiding this comment.
That might cause again "laggy" reactivity. Resize does not happen that often so I think it is fine not to have it debounced.
|
I built this branch and I see that space is allocated for sidebar even though it is not opened
|
LukasHirt
force-pushed
the
fix/sidebar-resizing
branch
from
73cbac5 to
19aadcb
Compare
Right 🤦 fixed by applying the adjusted width only when the sidebar is open. |
Fixed various issues with sidebar resizing. Close button is no longer pushed away, resize event is added, and correct breakpoint is used.
LukasHirt
force-pushed
the
fix/sidebar-resizing
branch
from
19aadcb to
06e7b80
Compare
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed various issues with sidebar resizing. Close button is no longer pushed away, resize event is added, and correct breakpoint is used.
Related Issue
Motivation and Context
Resilient layout 💪
How Has This Been Tested?
Screenshots (if appropriate):
Zaznam.obrazovky.2024-12-18.v.10.58.06.mov
Types of changes
Open tasks: