fix: error parsing in delete- and paste-worker #11684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors in workers need to be constructed manually in the main thread since they can't be serialized and passed from the worker to the main thread. This also fixes the issue with the missing request ids in failing copy, move and delete requests.
JammingBen
force-pushed
the
fix/error-parsing-workers
branch
from
bb5dd7d to
b1173ae
Compare
|
kulmann
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors in workers need to be constructed manually in the main thread since they can't be serialized and passed from the worker to the main thread.
This also fixes the issue with the missing request ids in failing copy, move and delete requests.
fixes #11678