Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds transparent sharing so share receivers can see other sharees when they have the permissions to do so.
Quite a bit of refactoring was needed for this because we didn't really support root spaces having shares. Personal spaces don't have any. Project spaces do, however, we handled them completely separate in the spaces store (via the
spaceMembers
prop).Now that share root spaces can have shares, I added functionality so those shares are being handled like regular indirect folder shares within the space. I also refactored space member shares to align with that. This might be a bit confusing at first sight, but IMO it's a lot cleaner now because it's the same for all kinds of spaces.
To test the transparent sharing part you need owncloud/ocis#9943.
Related Issue
Types of changes