-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mark external user shares in sidebar #11394
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
77f7e8b
to
dda3f68
Compare
Marks external user shares in the sidebar so they can be distinguished from internal shares.
dda3f68
to
9c4d87f
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With most recent ocis the external shares are not displayed with the globe icon for me but with the avatar-style-initials. Does this work for you?
Works fine for me, yes. Does the server respond correctly? The response of the |
As discussed in zoom: issue was that I tried to do this with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🤩
Description
Marks external user shares in the sidebar so they can be distinguished from internal shares.
Related Issue
Screenshots:
Types of changes