-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keyboard actions for deactivated resources #11342
Conversation
f27fbbd
to
8900fea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this disables the context menu in the tiles view for disabled spaces, actions like enable/delete life in there, and therefore should be accessible.
As you are already on it, the show members button will still be shown in the tiles view on a disabled space, clicking on that button opens the sidebar and ends in an endless loading animation. We might need to disable the show members button, but I think seeing members was possible on a disabled space, before switching to sharing ng 🤔
Prevents actions for disabled resources from being accessible via keyboard navigation. This is achieved by either disabling them (checkboxes) or hiding them (rename action, quick actions).
8900fea
to
503ea48
Compare
Good catch, should be fixed now.
IMO this is a server issue, listing members should be possible for disabled spaces. I'll create an issue in the oCIS repo for that 👍 Edit: owncloud/ocis#9764 |
Thank you, I took the opportunity, to disable the edit description action when space is disabled and don't load previews, since we don't have access to those files when disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you commited some vitest files by accident
Quality Gate passedIssues Measures |
Description
Prevents actions for disabled resources from being accessible via keyboard navigation. This is achieved by either disabling them (checkboxes) or hiding them (rename action, quick actions).
Related Issue
Types of changes