Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyboard actions for deactivated resources #11342

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

JammingBen
Copy link
Contributor

Description

Prevents actions for disabled resources from being accessible via keyboard navigation. This is achieved by either disabling them (checkboxes) or hiding them (rename action, quick actions).

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Aug 8, 2024
@JammingBen JammingBen force-pushed the fix/disabled-resource-keyboard-navigation branch 3 times, most recently from f27fbbd to 8900fea Compare August 8, 2024 09:39
@JammingBen JammingBen marked this pull request as ready for review August 8, 2024 10:28
@JammingBen JammingBen requested a review from AlexAndBear August 8, 2024 10:28
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this disables the context menu in the tiles view for disabled spaces, actions like enable/delete life in there, and therefore should be accessible.

As you are already on it, the show members button will still be shown in the tiles view on a disabled space, clicking on that button opens the sidebar and ends in an endless loading animation. We might need to disable the show members button, but I think seeing members was possible on a disabled space, before switching to sharing ng 🤔

Prevents actions for disabled resources from being accessible via keyboard navigation. This is achieved by either disabling them (checkboxes) or hiding them (rename action, quick actions).
@JammingBen JammingBen force-pushed the fix/disabled-resource-keyboard-navigation branch from 8900fea to 503ea48 Compare August 8, 2024 12:52
@JammingBen
Copy link
Contributor Author

JammingBen commented Aug 8, 2024

Unfortunately this disables the context menu in the tiles view for disabled spaces, actions like enable/delete life in there, and therefore should be accessible.

Good catch, should be fixed now.

As you are already on it, the show members button will still be shown in the tiles view on a disabled space, clicking on that button opens the sidebar and ends in an endless loading animation. We might need to disable the show members button, but I think seeing members was possible on a disabled space, before switching to sharing ng 🤔

IMO this is a server issue, listing members should be possible for disabled spaces. I'll create an issue in the oCIS repo for that 👍 Edit: owncloud/ocis#9764

@JammingBen JammingBen requested a review from AlexAndBear August 8, 2024 12:54
@AlexAndBear
Copy link
Contributor

Thank you, I took the opportunity, to disable the edit description action when space is disabled and don't load previews, since we don't have access to those files when disabled

Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you commited some vitest files by accident

@JammingBen JammingBen requested a review from AlexAndBear August 8, 2024 13:20
Copy link

sonarqubecloud bot commented Aug 8, 2024

@JammingBen JammingBen enabled auto-merge August 8, 2024 13:32
@JammingBen JammingBen merged commit dba04e0 into master Aug 8, 2024
3 checks passed
@kulmann kulmann deleted the fix/disabled-resource-keyboard-navigation branch September 5, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actions for disabled resources can be triggered via keyboard
2 participants