Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: make routes lazy #11089

Closed
wants to merge 1 commit into from
Closed

perf: make routes lazy #11089

wants to merge 1 commit into from

Conversation

JammingBen
Copy link
Contributor

Description

Makes all routes lazy so their components don't get loaded with the initial load, but when navigating to the routes.

The ComponentLoader is basically a component wrapping the route components to display a loading spinner during the loading times.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jun 24, 2024
Copy link

update-docs bot commented Jun 24, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Makes all routes lazy so their components don't get loaded with the initial load, but when navigating to the routes.
@JammingBen
Copy link
Contributor Author

I'm a bit torn here. It adds a bit of complexity while (currently) having near to no impact (Web now loads smaller but more chunks, even resulting in ~10-20ms more initial loading time - however this is not noticable). There might be situations in the future where this would be useful though, e.g. when some route component loads a lot of dependencies.

@kulmann @dschmidt any opinions from your side?

@JammingBen
Copy link
Contributor Author

Closing here since we're currently not planing this.

@JammingBen JammingBen closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make routes lazy
1 participant