Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reduce network load on token renewal #11077

Merged
merged 1 commit into from
Jun 21, 2024
Merged

perf: reduce network load on token renewal #11077

merged 1 commit into from
Jun 21, 2024

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jun 20, 2024 •
edited
Loading

Description

Reduces the network load on token renewal by not bootstrapping the whole application. Parts that are skipped loading during token renewal are:

  • loading applications
  • loading the inter font
  • loading translations
  • loading the theme

Related Issue

Benchmarks

Network load during token renewal - before:

Pasted Graphic 4

Network load during token renewal - after:

Pasted Graphic 3

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jun 20, 2024
@JammingBen JammingBen force-pushed the perf/token-renewal branch 4 times, most recently from 566f5fb to 679ff37 Compare June 20, 2024 12:36
@JammingBen JammingBen marked this pull request as ready for review June 20, 2024 13:27
kulmann
kulmann approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🥳

changelog/unreleased/enhancement-reduce-network-load-on-token-renewal Outdated Show resolved Hide resolved
packages/web-runtime/src/container/bootstrap.ts Outdated Show resolved Hide resolved
@JammingBen
perf: reduce network load on token renewal
b83aa5e 
Reduces the network load on token renewal by not bootstrapping the whole application. Parts that are skipped loading during token renewal are:

* loading applications
* loading the inter font
* loading translations
* loading the theme
@JammingBen JammingBen force-pushed the perf/token-renewal branch from 679ff37 to b83aa5e Compare June 21, 2024 07:13
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JammingBen JammingBen merged commit c9c60b1 into master Jun 21, 2024
3 checks passed
@micbar micbar mentioned this pull request Jul 8, 2024
Closed
19 tasks
@kulmann kulmann deleted the perf/token-renewal branch September 5, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent loading and initializing all apps on token renewal
2 participants
@JammingBen @kulmann