Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] add e2e test to view real time update of content by real/loggedIn user #10958

Merged

Conversation

anon-pradip
Copy link
Contributor

@anon-pradip anon-pradip commented May 24, 2024

Description

This test ensures that:

  • when a file shared with "Can view" permission by file creator using sidebar panel is opened by sharee, the sharee can not change content of file
  • when a file shared with "Can edit" permission by file creator using sidebar panel is opened by sharee, the sharee can change content of file and the changes are seen in real-time in both Collabora and OnlyOffice environments .

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

Comment on lines +42 to +48
When "Alice" shares the following resource using the sidebar panel
| resource | recipient | type | role | resourceType |
| OpenDocument.odt | Brian | user | Can view | file |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirajacharya2 Should the scenario flow be exact like it is in #10750 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't matter to me if we can cover this bug owncloud/ocis#8060

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anon-pradip Please, confirm that this behavior is checked

Copy link
Contributor Author

@anon-pradip anon-pradip May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saw-jan @nirajacharya2 Regarding owncloud/ocis#8060
After the 4th step i.e open the file and don't close it as marie, the permission can not be changed for:
5th step i.e change the permission to view as admin.
Since the file is opened in marie's editor, we can not change the permission from admin's window because the file is locked with hover warning Resource is temporarily locked, unable to manage share in the permission changing dropdown.
Then what improvements (if any) could be done next?

@anon-pradip anon-pradip force-pushed the test/update-file-by-loggedin-user branch 2 times, most recently from e557396 to fd2fe97 Compare May 27, 2024 07:01
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anon-pradip anon-pradip force-pushed the test/update-file-by-loggedin-user branch from fd2fe97 to fdaf4dd Compare May 27, 2024 08:40
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit ad6733c into owncloud:master May 28, 2024
3 checks passed
@anon-pradip anon-pradip deleted the test/update-file-by-loggedin-user branch May 29, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants