Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-only] Replace UI tests. link indication #10905

Merged
merged 1 commit into from
May 15, 2024
Merged

[test-only] Replace UI tests. link indication #10905

merged 1 commit into from
May 15, 2024

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented May 14, 2024 •
edited
Loading

related #10259

  • add e2e tests for link-direct/indirect indicatation
  • add e2e tests for user-direct/indirect indicatation
  • navigate and show recources in the shared via link page
  • deleted old UI test tests/acceptance/features/webUISharingPublicManagement
  • check copy link to clipboard button and open link
  • moved canUserEditResource and showShareIndicatorSelector from space to recources

@update-docs Update Docs
Copy link

update-docs bot commented May 14, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor force-pushed the shareIndication branch 2 times, most recently from 5d8a097 to 4e0c0ed Compare May 15, 2024 10:24
@ScharfViktor ScharfViktor requested a review from saw-jan May 15, 2024 11:13
saw-jan
saw-jan approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ScharfViktor ScharfViktor merged commit a57a1cf into master May 15, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the shareIndication branch May 15, 2024 11:50
This was referenced May 16, 2024
Closed
Merged
ScharfViktor added a commit that referenced this pull request May 16, 2024
@ScharfViktor
link indication (#10905)
dbab94a
@ScharfViktor ScharfViktor mentioned this pull request May 16, 2024
Merged
ScharfViktor added a commit that referenced this pull request May 17, 2024
@ScharfViktor @saw-jan
[full-ci]Port #10919 #10905 #10873 #10864 #10841 to stable (#10927)
b54f5e7 
* combine steps (#10841)

* [test-only] e2e tests for space sse events (#10864)

* e2e tests for space sse events

* rework assertions

* [test-only] check lock sse event (#10873)

* check lock sse event

* lint fix

* link indication (#10905)

* replace UI link test (#10919)

* back resourceNameSelector

* fix after rebase

* test: revert changes needed for stable branch

* test: fix scenario

---------

Co-authored-by: Saw-jan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@S-Panta S-Panta Awaiting requested review from S-Panta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScharfViktor @saw-jan