-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] [tests-only] Fixed failure in lock test #10886
Conversation
Ah, PR doesn't have full-ci in the title so we didn't catch it. |
The failure is due to incomplete implementation of step Then(
/^"([^"]*)" (should|should not) be able to manage share with user "([^"]*)"$/,
async function (
this: World,
stepUser: any,
actionType: string,
recipient: string
): Promise<void> {
const { page } = this.actorsEnvironment.getActor({ key: stepUser })
const shareObject = new objects.applicationFiles.Share({ page })
const changeRole = shareObject.changeRoleLocator(
this.usersEnvironment.getUser({ key: recipient })
)
const changeShare = shareObject.changeShareLocator(
this.usersEnvironment.getUser({ key: recipient })
)
if (actionType === 'should') {
await expect(changeRole).not.toBeDisabled()
await expect(changeShare).not.toBeDisabled()
} else {
await expect(changeRole).toBeDisabled()
await expect(changeShare).toBeDisabled()
}
}
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
Description
The file is opened with
Collabora
andthen
step is checked withOnlyOffice
so the selector ofOnlyOffice
is not found incollabora
editor.The failure arose after this PR #10873 .
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes