Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [tests-only] Fixed failure in lock test #10886

Merged
merged 3 commits into from
May 8, 2024

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented May 8, 2024

Description

The file is opened with Collabora and then step is checked with OnlyOffice so the selector of OnlyOffice is not found in collabora editor.
The failure arose after this PR #10873 .

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@grgprarup grgprarup self-assigned this May 8, 2024
@saw-jan
Copy link
Member

saw-jan commented May 8, 2024

The failure arose after this PR #10873 .

Ah, PR doesn't have full-ci in the title so we didn't catch it.

@grgprarup
Copy link
Contributor Author

The failure is due to incomplete implementation of step And "Alice" should be able to manage share with user "Brian", the sidebar panel of share is not open.

Then(
  /^"([^"]*)" (should|should not) be able to manage share with user "([^"]*)"$/,
  async function (
    this: World,
    stepUser: any,
    actionType: string,
    recipient: string
  ): Promise<void> {
    const { page } = this.actorsEnvironment.getActor({ key: stepUser })
    const shareObject = new objects.applicationFiles.Share({ page })
    const changeRole = shareObject.changeRoleLocator(
      this.usersEnvironment.getUser({ key: recipient })
    )
    const changeShare = shareObject.changeShareLocator(
      this.usersEnvironment.getUser({ key: recipient })
    )

    if (actionType === 'should') {
      await expect(changeRole).not.toBeDisabled()
      await expect(changeShare).not.toBeDisabled()
    } else {
      await expect(changeRole).toBeDisabled()
      await expect(changeShare).toBeDisabled()
    }
  }
)

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@grgprarup grgprarup merged commit ae71fa0 into master May 8, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/app-provider-test branch May 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App provider tests failing in nightly while waiting for locator
2 participants