Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]add test for updating content of file #10838

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

anon-pradip
Copy link
Contributor

@anon-pradip anon-pradip commented Apr 26, 2024

Description

This PR tests the updating of content of a file inside the personal space as to reflect new content edits.

Related Issue

Motivation and Context

  • e2e test for updating the content of file has not been implemented

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2024

CLA assistant check
All committers have signed the CLA.

@anon-pradip anon-pradip force-pushed the test/update-content-of-file branch from 94c6d5a to 7c5a4bb Compare April 26, 2024 07:20
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM 👍

@anon-pradip anon-pradip force-pushed the test/update-content-of-file branch from 7c5a4bb to d3d70bd Compare April 26, 2024 08:34
@anon-pradip anon-pradip force-pushed the test/update-content-of-file branch from d3d70bd to 1698b39 Compare April 26, 2024 09:36
@anon-pradip anon-pradip force-pushed the test/update-content-of-file branch from 1698b39 to c8a10e3 Compare April 26, 2024 09:44
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@anon-pradip anon-pradip requested a review from SagarGi April 29, 2024 04:00
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan
Copy link
Member

saw-jan commented Apr 29, 2024

Port to the stable-8 branch please (PR should be in the stable branch first)

@saw-jan saw-jan merged commit 46e0786 into owncloud:master Apr 29, 2024
3 checks passed
@anon-pradip anon-pradip deleted the test/update-content-of-file branch April 29, 2024 10:00
anon-pradip added a commit to anon-pradip/web that referenced this pull request Apr 29, 2024
…10838)

* test: add test for updating content of file

* refactor: remove acceptance tests scenarios for updating content of file
saw-jan pushed a commit that referenced this pull request Apr 29, 2024
…10851)

* test: add test for updating content of file

* refactor: remove acceptance tests scenarios for updating content of file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants