Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 10814: Make OcModal vertically scrollable #10816

Merged
merged 1 commit into from
May 15, 2024
+12 −4
Merged

Fix 10814: Make OcModal vertically scrollable #10816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-oc-modal-scroll-small-screens
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Vertical scroll for OcModal on small screens

We've fixed an issue where modals were not scrollable on screens with small heights.

https://github.com/owncloud/web/issues/10814
https://github.com/owncloud/web/pull/10816
10 changes: 6 additions & 4 deletions packages/design-system/src/components/OcModal/OcModal.vue
View file
Open in desktop
pascalwengerter marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -434,12 +434,14 @@ export default defineComponent({
}

.oc-modal {
max-width: 500px;
width: 100%;
box-shadow: 5px 0 25px rgba(0, 0, 0, 0.3);
background-color: var(--oc-color-background-default);
border: 1px solid var(--oc-color-input-border);
border-radius: 15px;
background-color: var(--oc-color-background-default);
box-shadow: 5px 0 25px rgba(0, 0, 0, 0.3);
max-height: 90vh;
max-width: 500px;
overflow: auto;
width: 100%;

&:focus {
outline: none;
Expand Down