Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download of files with special chars #10813

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Apr 22, 2024

Description

Fixes downloads of files with special chars, especially # in the filename by encoding the webdav path.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Copy link

update-docs bot commented Apr 22, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann force-pushed the fix-downloads-special-chars branch from db213ce to 3a6d7f9 Compare April 22, 2024 12:29
@kulmann kulmann self-assigned this Apr 22, 2024
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, linter fails though

@kulmann kulmann force-pushed the fix-downloads-special-chars branch from 3a6d7f9 to 503faf3 Compare April 22, 2024 19:08
@kulmann kulmann enabled auto-merge April 22, 2024 19:13
Copy link

sonarcloud bot commented Apr 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants